Closed
Conversation
Contributor
📋 Code Owners Summary1 file(s) changed, 1 with assigned owners 1 team(s) affected: Owners and Their Files
|
Contributor
HKDF() return value was only checked via DCHECK(), which is compiled out in release (official) builds. If HKDF failed in production, the secret key would remain zero-initialized, producing a deterministic and publicly-known signing keypair. Replace DCHECK with a runtime check that returns std::nullopt on failure, consistent with the existing error path for invalid seed size.
github-actions
bot
force-pushed
the
contributor-dev-doshi-fix/signer-hkdf-check-release-builds
branch
from
be68df1 to
3867c29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is created to run CI on the changes proposed in PR #34262 by @dev-doshi.
This PR should not be merged.